Complete refactoring of code to block conversion logic to be config driven#4702
Closed
ebeetles wants to merge 1 commit intosugarlabs:masterfrom
Closed
Complete refactoring of code to block conversion logic to be config driven#4702ebeetles wants to merge 1 commit intosugarlabs:masterfrom
ebeetles wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Member
|
@ebeetles is the PR still relevant? Can we close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to use a JSON config: ast2blocks.json so that the logic behind converting code to blocks is as generic as possible.
Right now code to blocks has support for all rhythm, flow, boxes, number, boolean, and dictionary palette blocks. As well as some blocks from action, pitch and tone palettes. Adding a new block for support is now as simple as adding the blocks path and properties into the JSON configuration.